[Gtk4] Support MenuItem images on GTK4 - #3441
Draft
akurtakov wants to merge 1 commit into
Draft
Conversation
akurtakov
marked this pull request as draft
July 15, 2026 16:36
Contributor
akurtakov
force-pushed
the
gtk4-menu-icons
branch
7 times, most recently
from
August 4, 2026 07:21
924149f to
9f101f4
Compare
akurtakov
force-pushed
the
gtk4-menu-icons
branch
from
September 8, 2026 08:50
9f101f4 to
8b1bbe3
Compare
GtkModelButton (GTK4's native menu row) never shows both an icon and text, so menu items with images rendered without their icon. Work around this by embedding a custom icon+label(+accelerator) GtkButton into the popover via gtk_popover_menu_add_child() for PUSH and CHECK items. The custom row uses the "modelbutton" CSS node so the theme's menu row rules apply to it, and its icons and the native rows' share one column via a GtkSizeGroup. CHECK rows carry a GtkCheckButton bound to the item's action as indicator; CASCADE and RADIO items keep the native GtkModelButton. Selection is kept in sync by motion and focus controllers on every popover: the highlight is re-derived from each row's prelight so it survives a submenu holding the pointer grab, stray focus selections are swept, and hovering a sibling closes an open submenu after a short delay. Themed workbenches (e.g. the e4 dark theme) override the row's selected background, so the highlight is painted by a display-wide provider keyed on a class instead. Injection is self-healing: GTK's "custom" ids are single-use, so a detached or rebuilt row is re-injected under a fresh id. Menubar drop-downs are located by their menu model rather than positionally, avoiding leaks and lost SWT.Show events during item changes. Contributes to eclipse-platform#2511 Assisted-by: Anthropic Claude Code (claude-sonnet-5) Assisted-by: Anthropic Claude Code (claude-fable-5-1)
akurtakov
force-pushed
the
gtk4-menu-icons
branch
from
September 11, 2026 11:17
8b1bbe3 to
fead2fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GtkModelButton (GTK4's native menu row) never shows both an icon and text, so PUSH menu items with images rendered without their icon. Work around this by embedding a custom icon+label(+accelerator) GtkButton into the popover via gtk_popover_menu_add_child() for PUSH items.
CASCADE, CHECK and RADIO items keep the native GtkModelButton, since GTK ties their submenu link / selection indicator to it and there is no way to reproduce that in a custom widget.
Injection is self-healing: GTK's "custom" ids are single-use once their placeholder slot is destroyed (e.g. by menu repopulation), so a detached widget is re-injected under a fresh id rather than reusing the stale one, which previously left dynamically-rebuilt items (like Run/Debug) invisible.
WIP towards #2511